This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Fetch page from outline #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've implemented the ability to get the page corresponding to an entry in the outline (aka table of contents). This is admittedly quick and dirty. It works on the handful of PDF files I tried it with, but I haven't actively sought out corner cases.
This commit adds support for finding the next or previous pages in the document. This is especially useful when the page number isn't known, e.g. because it was reached via the outline.
I didn't realize I already had a handy reference to *pdf.Reader present in Outline (by way of Value). This means Page() can be a method of Outline, rather than a method of *pdf.Reader, which seems to me a more logical place for it. Best to change this now, before anyone else might be using this code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the ability to get the page corresponding to an entry
in the outline (aka table of contents), and to walk to the next or previous
page in the document given just a Page object.
This is admittedly quick and dirty. It works on the handful of PDF
files I tried it with, but I haven't actively sought out corner cases.