Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata improvemens #16

Merged
merged 2 commits into from
Dec 4, 2024
Merged

metadata improvemens #16

merged 2 commits into from
Dec 4, 2024

Conversation

fmigneault
Copy link
Contributor

  • adds title override option
  • adds description override option (which allows injecting a nice HTML rendering about the record to be generated)
  • avoids completely overriding related_identifiers if some were already provided in .zenodo.json

fmigneault added a commit to crim-ca/weaver that referenced this pull request Nov 24, 2024
@fmigneault
Copy link
Contributor Author

Hi @vsoch

Let me know if something else must be adjusted, but I believe those would be nice improvements for the action (thanks for creating it BTW!)

@vsoch
Copy link
Contributor

vsoch commented Nov 24, 2024

These are great changes! Did you run it anywhere as an example to show?

@fmigneault
Copy link
Contributor Author

I'm attempting it in crim-ca/weaver#767
Will report back the results once I release a version with it.

@vsoch
Copy link
Contributor

vsoch commented Dec 3, 2024

@fmigneault it looks good to me!

https://zenodo.org/records/14270893

When you give the 👍 you are done with changes here, I am happy to merge this. Thanks again for the contribution!

@fmigneault
Copy link
Contributor Author

Yes. All done. 👍 Thanks

@vsoch vsoch merged commit 59b48fd into rseng:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants