-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup build logic #252
Merged
Merged
Cleanup build logic #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 699 files ±0 699 suites ±0 37m 7s ⏱️ -1s Results for commit d5c1b35. ± Comparison against base commit 2239c5c. This pull request removes 201 and adds 201 tests. Note that renamed tests count towards both.
This pull request removes 9 skipped tests and adds 9 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
adb59a1
to
ec8442c
Compare
* align build-logic plugins with Gradle suggestions; * introduce build-logic-settings for multiple settings configuration; * move kotlin version to Version Catalog; * move build-logic to root of the project; * remove build-parameters; * rename build-logic plugins; * minor cleanup in the publication script; * drop target-specific convention plugins, as KGP now generates; accessors; * use targets helpers in projects; * drop template convention plugins; * create test aggregate tasks; * reduce usages of OptIns; * use jvm-default=all (easier compatibility in future); * drop test server completely for now from `rsocket-transport-tests`; * Update some Gradle properties; * implement small DSL for including projects;
OlegDokuka
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall, the idea is that latest Gradle/KGP versions and suggesting allowed to cleanup some code.
Just build-related changes:
Code/functionality related changes:
rsocket-transport-tests