Skip to content

Commit

Permalink
ban numpy 1.25.0 -- leads to segfault in tests/tensor_ops/test_getite…
Browse files Browse the repository at this point in the history
…m.py::test_getitem_advindex_bool_bkwdprop
  • Loading branch information
rsokl committed Jul 3, 2023
1 parent fe1b2a8 commit 370f4c6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"Topic :: Scientific/Engineering",
]

INSTALL_REQUIRES = ["numpy >= 1.20", "typing-extensions >= 4.1.0, !=4.6.0"]
# tests/tensor_ops/test_getitem.py::test_getitem_advindex_bool_bkwdprop segfaults
INSTALL_REQUIRES = ["numpy >= 1.20, !=1.25.0", "typing-extensions >= 4.1.0, !=4.6.0"]
TESTS_REQUIRE = ["pytest >= 3.8", "hypothesis >= 6.17.1", "scipy"]

DESCRIPTION = "Brings drop-in automatic differentiation to NumPy"
Expand Down
2 changes: 1 addition & 1 deletion src/mygrad/tensor_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -2346,7 +2346,7 @@ def __gt__(self, other: ArrayLike) -> np.ndarray:
def __ge__(self, other: ArrayLike) -> np.ndarray:
return np.ndarray.__ge__(self.data, asarray(other))

def __imatmul__(self, other):
def __imatmul__(self, other): # pragma: no cover
raise TypeError(
"In-place matrix multiplication is not (yet) supported. "
"Use 'a = a @ b' instead of 'a @= b'"
Expand Down

0 comments on commit 370f4c6

Please sign in to comment.