Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google font specifying all font options #828

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kylebutts
Copy link

@kylebutts kylebutts commented Aug 19, 2021

Just a small thing. Here, you specify which font variants and weights to load. This causes error with pagedown::chrome_print because not every google font has every option. Fortunately, you don't need to specify any and it will load them all. So I think it's better to just delete that part of the line

gt/R/helpers.R

Line 2237 in df86e0c

":ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap');"

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ rich-iannone
❌ kylebutts
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants