Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add pkgdown function reference page #925

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

jack-davison
Copy link
Contributor

Since #902 {leaflet} has used {pkgdown}

One page that wasn't touched was https://rstudio.github.io/leaflet/reference/index.html, which is a massive list of unsorted functions.

This PR attempts to sort them into an ordered list that makes them easier to parse.

It's likely not perfect, but a step in the right direction! I tried to use the articles as a bit of a guide as to how to link the functions thematically.

PR task list:

  • News N/A
  • Tests N/A
  • Update documentation with devtools::document()

@schloerke schloerke changed the title Sort pkgdown function reference page docs: Add pkgdown function reference page Jul 26, 2024
@schloerke
Copy link
Contributor

Thank you! This is great!

@schloerke schloerke merged commit 0d3bb3e into rstudio:main Jul 26, 2024
12 checks passed
@jack-davison jack-davison deleted the docs/sort-pkgdown-ref-page branch July 26, 2024 15:45
@jack-davison
Copy link
Contributor Author

jack-davison commented Jul 26, 2024

You're very welcome @schloerke! Strangely it doesn't look like its carried over to https://rstudio.github.io/leaflet/reference/index.html though...

image

schloerke added a commit that referenced this pull request Jul 26, 2024
@schloerke
Copy link
Contributor

I'm hoping it was a race condition between two website jobs.

I added a commit to main to trigger another build.

@jack-davison
Copy link
Contributor Author

Seems like it's failed again - very bizarre as it works locally

@schloerke
Copy link
Contributor

Ah! Found where it was going: https://github.com/rstudio/leaflet/tree/4e438c9025ad83b1797c4fc080c0b7fbeb72a8c9/dev

Turned off dev mode here: 39ffbca

🎉 : https://rstudio.github.io/leaflet/reference/index.html

Thank you again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants