Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getTranslateDOMPositionXY support enableTransform option #74

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

myNameIsDu
Copy link
Member

@myNameIsDu myNameIsDu commented Jan 11, 2024

ref: rsuite/rsuite-table#481

To support this feature, we have to add additional options, However, there's a point we need to notice: the default option is the whole object. To be compatible with the old value like {enableTranslate3d: false}, we need to separate the whole object as individual properties and set default values for the individual properties.

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dom-lib ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 6:42am

@simonguo simonguo merged commit 8c0d762 into rsuite:master Jan 11, 2024
5 checks passed
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants