Add Username, Password, Database and Unix Socket support. #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SH4LIN
requested changes
Oct 14, 2024
Comment on lines
+279
to
+282
| 'redis_unix_socket' => '', | ||
| 'redis_database' => 0, | ||
| 'redis_username' => '', | ||
| 'redis_password' => '', |
| $data['redis_hostname'] = RT_WP_NGINX_HELPER_REDIS_HOSTNAME; | ||
| $data['redis_port'] = RT_WP_NGINX_HELPER_REDIS_PORT; | ||
| $data['redis_prefix'] = RT_WP_NGINX_HELPER_REDIS_PREFIX; | ||
| $data['redis_database'] = defined('RT_WP_NGINX_HELPER_REDIS_DATABASE') ? RT_WP_NGINX_HELPER_REDIS_DATABASE : 0; |
|
|
||
| $hostname = empty( $nginx_helper_admin->options['redis_unix_socket'] ) ? $nginx_helper_admin->options['redis_hostname'] : $nginx_helper_admin->options['redis_unix_socket']; | ||
| $port = empty( $nginx_helper_admin->options['redis_unix_socket'] ) ? $nginx_helper_admin->options['redis_port'] : 0; | ||
|
|
||
| $this->redis_object->connect( |
There was a problem hiding this comment.
On my local setup, there’s no Nginx server or Redis installed. When I switch branches from master to your branch, the code throws a fatal error. The plugin is trying to connect, but the connection is being refused. If the plugin is attempting to make a connection, there should also be a fatal error in the master branch.
Please take a look into this
There was a problem hiding this comment.
@SH4LIN I am unable to replicate the issue on my end. Can you please share the error here if possible?
| @@ -22,6 +22,12 @@ | |||
| 'redis_hostname', | |||
| 'redis_port', | |||
| 'redis_prefix', | |||
| 'redis_database', | |||
| </td> | ||
| </tr> | ||
| <tr> |
There was a problem hiding this comment.
Fix the indentation and use tabs instead of the space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to add support for including the Username, Password, Database and Unix Socket Path for Redis.
Type
Reference Issue
Screenshots
Testing
The code has been tested locally and is working as expected.