[rt_media attachment_id=XX] short does not work

[kjnanda]

Using this shortcode does not show anything and throws PHP Notice for Undefined variable: media_url

Please check this screenshot.

[Pathan-Amaankhan]

I tried replicating this issue but was unable to replicate it for audio & video attachments but was able to replicate this error for image type attachments.

After further investigation found that the rt_media shortcode does not support image type attachments as there is no generation of output if we pass the id of the image type attachment as attachment_id.

transcoder/admin/rt-transcoder-functions.php

Lines 40 to 103 in 7c7c5d0

	function rt_media_shortcode( $attrs, $content = '' ) {
	if ( empty( $attrs['attachment_id'] ) ) {
	return false;
	}
	$attachment_id = $attrs['attachment_id'];
	$type = get_post_mime_type( $attachment_id );
	if ( empty( $type ) ) {
	return false;
	}
	$mime_type = explode( '/', $type );
	if ( 'video' === $mime_type[0] ) {
	$video_shortcode_attributes = '';
	$media_url = rtt_get_media_url( $attachment_id );
	$poster = rt_media_get_video_thumbnail( $attachment_id );
	$attrs['src'] = $media_url;
	$attrs['poster'] = $poster;
	foreach ( $attrs as $key => $value ) {
	$video_shortcode_attributes .= ' ' . $key . '="' . $value . '"';
	}
	$content = do_shortcode( "[video {$video_shortcode_attributes}]" );
	} elseif ( 'audio' === $mime_type[0] ) {
	$media_url = rtt_get_media_url( $attachment_id, 'mp3' );
	$audio_shortcode_attributes = 'src="' . $media_url . '"';
	foreach ( $attrs as $key => $value ) {
	$audio_shortcode_attributes .= ' ' . $key . '="' . $value . '"';
	}
	$content = do_shortcode( "[audio {$audio_shortcode_attributes}]" );
	}
	if ( is_file_being_transcoded( $attachment_id ) ) {
	$content .= '<p class="transcoding-in-progress"> ' . esc_html__( 'This file is being transcoded. Please wait.', 'transcoder' ) . '</p>';
	}
	/**
	* Allow user to filter [rt_media] short code content.
	*
	* @since 1.0.0
	*
	* @param string $content Activity content.
	* @param int $attachment_id ID of attachment.
	* @param string $media_url URL of the media.
	* @param string $media_type Mime type of the media.
	*/
	return apply_filters( 'rt_media_shortcode', $content, $attachment_id, $media_url, $mime_type[0] );
	}
	add_shortcode( 'rt_media', 'rt_media_shortcode' );

@gagan0123 please let me know if this functionality is working as it should and if are we going to extend the functionality for image-type attachments also.

cc: @aviral-mittal

[gagan0123]

@Pathan-Amaankhan

Image type attachments are not supposed to be handled as of now, but still lets display a translatable message saying "Image attachments are not handled by Transcoder plugin."

Apart from that, handle the "Undefined variable: media_url" notice as well, by passing the correct media URL, as any third party plugin that want to handle image attachments as well can still make use of the filter.