Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-139: [rt_media attachment_id=XX] short does not work [Develop] #259

Merged
merged 1 commit into from
Feb 3, 2023
Merged

GH-139: [rt_media attachment_id=XX] short does not work [Develop] #259

merged 1 commit into from
Feb 3, 2023

Conversation

Pathan-Amaankhan
Copy link
Member

Description

  • This PR:
    • adds a message to the rt_media shortcode when the image attachment ID is added in attachment_id.
    • Fixes the Undefined variable: $media_url by initializing $media_url with a default value(.i.e. '').

Fixes/Covers

@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as draft February 2, 2023 13:54
@Pathan-Amaankhan Pathan-Amaankhan changed the base branch from develop to GH-31 February 3, 2023 06:54
@Pathan-Amaankhan Pathan-Amaankhan changed the base branch from GH-31 to develop February 3, 2023 06:55
@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as ready for review February 3, 2023 06:57
@Pathan-Amaankhan Pathan-Amaankhan merged commit 3089c59 into develop Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagan0123 gagan0123 gagan0123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pathan-Amaankhan @gagan0123