Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: rt-player block #294

Closed
wants to merge 4 commits into from
Closed

Conversation

pranvinit
Copy link

@pranvinit pranvinit commented Nov 8, 2024

Types of changes

What types of changes does your code introduced to project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Details

  1. Update the webpack and babel packages and config files to modern standards while maintaining same output.
  2. Remove unnecessary/redundant packages from dependencies.
  3. Create the transcoder/rt-player block as per requirements.
  4. Add the block build and registration code.

Demo

Screenshot 2024-11-08 at 1 19 58 PM

Checklist

Put an x in the boxes that apply.

  • Lint and tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

Closing issues

Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

⚠️ 2 warnings


Powered by rtCamp's GitHub Actions Library

inc/classes/class-assets.php Show resolved Hide resolved
inc/classes/class-blocks.php Show resolved Hide resolved
Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 8 errors


skipped-files

Maximum number of lines exceeded (15000):

  • assets/build/blocks/rt-player/index.js

Note that the above file(s) were not analyzed due to their length.


Powered by rtCamp's GitHub Actions Library

@pranvinit pranvinit closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants