Add capability to load DynamicType directly from XML #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gen -convertToXml and specify include paths programmatically
alexcamposruiz
requested changes
Dec 15, 2020
| @@ -124,7 +124,44 @@ void init_class_defs(py::class_<DynamicType>& cls) | |||
| .def(py::self == py::self, | |||
| "Compare DynamicType objects for equality.") | |||
| .def(py::self != py::self, | |||
| "Compare DynamicType objects for inequality."); | |||
| "Compare DynamicType objects for inequality.") | |||
| .def_static( | |||
There was a problem hiding this comment.
This functionality exists in the QosProvider. Did you need to add it here for some reason?
There was a problem hiding this comment.
This adds two things that, to the best of my knowledge, are not handled by the QosProvider public API type functions:
- It allows for the use of a type's XML right out of
rtiddsgen -convertToXmlwithout having to first include it from a QoS file. Trying to load such an XML with QosProvider produces an error:
rti.connextdds.Error:
DDS_XMLStruct_initialize:!init XML struct object
DDS_XMLStruct_newI:!init XML struct object
RTIXMLParser_onStartTag:Parse error at line 3: Error processing tag 'struct'
- A user can specify include search paths for XML type dependencies. This can be useful for specifying type locations relative to the script's path in code. I think there is a way to do this in QoS if you know all of the XML files and use environment variables to specify the path, but maybe there is a better way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes direct output from rtiddsgen -convertToXml and allows for specifying include paths programmatically, presenting an alternative to QosProvider for getting types from files.