Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect attributes in generated meta tags #106

Open
apjanke opened this issue Dec 22, 2018 · 2 comments
Open

Incorrect attributes in generated meta tags #106

apjanke opened this issue Dec 22, 2018 · 2 comments

Comments

@apjanke
Copy link

apjanke commented Dec 22, 2018

In the HTML output, there are a couple meta tags being generated by Ronn.

  <meta http-equiv='content-type' value='text/html;charset=utf8'>
  <meta name='generator' value='Ronn/v0.7.3 (http://github.com/rtomayko/ronn/tree/0.7.3)'>

I think these are invalid. The meta element doesn't take a name attribute; it takes a content attribute instead. These should be:

  <meta http-equiv='content-type' content='text/html;charset=utf8'>
  <meta name='generator' content='Ronn/v0.7.3 (http://github.com/rtomayko/ronn/tree/0.7.3)'>
@apjanke
Copy link
Author

apjanke commented Dec 22, 2018

Superset of #81.

@apjanke
Copy link
Author

apjanke commented Dec 23, 2018

Fixed in my Ronn-NG fork at apjanke/ronn-ng@d645829.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant