Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Danish endpoint by converting href attributes to lowercase #415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chrille0234
Copy link

Navigating to the Danish endpoint is problematic. The current anchor leads you to /lang/da_DK, which provides no translations. However, /lang/da_dk does work.

To address this issue, I added a Handlebars helper called lowerCase which converts the endpoint to lowercase. This makes sure that all tags href attributes are in lowercase, ensuring the correct endpoint is used.

@Chrille0234 Chrille0234 changed the title Ensure all <a> tags href attributes are in lowercase Fix issue with Danish endpoint by converting href attributes to lowercase Dec 5, 2024
@Chrille0234
Copy link
Author

Turns out the issue is in da_dk.json. the "lang" property is set to da_DK when it should be all lowercase. But I guess this prevents it from being a potential problem later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant