Skip to content

Commit

Permalink
MINOR: fix kraft upgrade system test (apache#14424)
Browse files Browse the repository at this point in the history
We should use DEV_BRANCH instead of DEV_VERSION in this case, otherwise, error will be thrown:

RunnerClient: kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_upgrade.from_kafka_version=3.6.0-SNAPSHOT.metadata_quorum=ISOLATED_KRAFT: FAIL: RemoteCommandError({'ssh_config': {'host': 'ducker10', 'hostname': 'ducker10', 'user': 'ducker', 'port': 22, 'password': '', 'identityfile': '/home/ducker/.ssh/id_rsa', 'connecttimeout': None}, 'hostname': 'ducker10', 'ssh_hostname': 'ducker10', 'user': 'ducker', 'externally_routable_ip': 'ducker10', '_logger': <Logger kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_upgrade.from_kafka_version=3.6.0-SNAPSHOT.metadata_quorum=ISOLATED_KRAFT-2 (DEBUG)>, 'os': 'linux', '_ssh_client': <paramiko.client.SSHClient object at 0xffffb35d5820>, '_sftp_client': <paramiko.sftp_client.SFTPClient object at 0xffffb35f8ca0>, '_custom_ssh_exception_checks': None}, '/opt/kafka-3.6.0-SNAPSHOT/bin/kafka-storage.sh format --ignore-formatted --config /mnt/kafka/kafka.properties --cluster-id I2eXt9rvSnyhct8BYmW6-w', 127, b'bash: line 1: /opt/kafka-3.6.0-SNAPSHOT/bin/kafka-storage.sh: No such file or directory\n')

Reviewers: Satish Duggana <[email protected]>
  • Loading branch information
showuon authored Sep 23, 2023
1 parent daf8a0d commit 6f9681e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/kafkatest/tests/core/kraft_upgrade_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from kafkatest.tests.produce_consume_validate import ProduceConsumeValidateTest
from kafkatest.utils import is_int
from kafkatest.version import LATEST_3_1, LATEST_3_2, LATEST_3_3, LATEST_3_4, LATEST_3_5, \
DEV_BRANCH, DEV_VERSION, KafkaVersion, LATEST_METADATA_VERSION
DEV_BRANCH, KafkaVersion, LATEST_METADATA_VERSION

#
# Test upgrading between different KRaft versions.
Expand Down Expand Up @@ -114,7 +114,7 @@ def run_upgrade(self, from_kafka_version):
@parametrize(from_kafka_version=str(LATEST_3_3), metadata_quorum=combined_kraft)
@parametrize(from_kafka_version=str(LATEST_3_4), metadata_quorum=combined_kraft)
@parametrize(from_kafka_version=str(LATEST_3_5), metadata_quorum=combined_kraft)
@parametrize(from_kafka_version=str(DEV_VERSION), metadata_quorum=combined_kraft)
@parametrize(from_kafka_version=str(DEV_BRANCH), metadata_quorum=combined_kraft)
def test_combined_mode_upgrade(self, from_kafka_version, metadata_quorum):
self.run_upgrade(from_kafka_version)

Expand All @@ -124,7 +124,7 @@ def test_combined_mode_upgrade(self, from_kafka_version, metadata_quorum):
@parametrize(from_kafka_version=str(LATEST_3_3), metadata_quorum=isolated_kraft)
@parametrize(from_kafka_version=str(LATEST_3_4), metadata_quorum=isolated_kraft)
@parametrize(from_kafka_version=str(LATEST_3_5), metadata_quorum=isolated_kraft)
@parametrize(from_kafka_version=str(DEV_VERSION), metadata_quorum=isolated_kraft)
@parametrize(from_kafka_version=str(DEV_BRANCH), metadata_quorum=isolated_kraft)
def test_isolated_mode_upgrade(self, from_kafka_version, metadata_quorum):
self.run_upgrade(from_kafka_version)

0 comments on commit 6f9681e

Please sign in to comment.