-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported Python versions 3.3 to 3.13 #269
Open
kieran-ryan
wants to merge
7
commits into
rubik:master
Choose a base branch
from
kieran-ryan:fix/supported-pythons
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update maximum Python version to match `tox.ini` and `README.rst`. - Add missing support versions 3.3-3.5, 3.10 and 3.11.
kieran-ryan
force-pushed
the
fix/supported-pythons
branch
from
December 23, 2024 18:27
64b972f
to
9c1c846
Compare
Python 3.13 released on the 7th of October 2024. https://www.python.org/downloads/release/python-3130/
kieran-ryan
force-pushed
the
fix/supported-pythons
branch
3 times, most recently
from
December 23, 2024 18:58
9df08f0
to
d335904
Compare
`colarama` v0.4.1 is incompatible with Python 3.3 so should not attempt install when using 3.3.
kieran-ryan
force-pushed
the
fix/supported-pythons
branch
from
December 23, 2024 21:54
d335904
to
a813251
Compare
- Removed Python 2 references and infrastructure - Bumped maximum `mando` version to `0.8.x` with Python 2 dropped - Automatically applied [ruff fixes for Python 2 deprecations](https://docs.astral.sh/ruff/rules/#pyupgrade-up): - UP004 - useless-object-inheritance - Class {name} inherits from object - UP008 - super-call-with-parameters - Use super() instead of super(__class__, self) - UP009 - utf8-encoding-declaration - UTF-8 encoding declaration is unnecessary - UP020 - open-alias - Use builtin open - UP025 - unicode-kind-prefix - Remove unicode literals from strings - UP030 - format-literals - Use implicit references for positional format fields - Manually resolved `UP036` deprecations (outdated-version-block) - Dropped deprecated `MAINTAINER` property from `Dockerfile`
- Drop defunct travis CI badge
Simplifies `pip install radon nbformat` to `pip install radon[notebook]`. Protects against changing underlying dependency in future.
kieran-ryan
force-pushed
the
fix/supported-pythons
branch
from
December 23, 2024 22:18
a813251
to
1d2cf66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
pip install radon[notebook]
)toml
extra install to poetry build⚡️ What's your motivation?
colorama
distribution since v4.2.0 (Adapt dependency on colorama according to python version #195)futures
dependency (chore: remove obsolete future dep #234) and incompatibilities with pyproject.toml support code (pyproject.toml support #236) - improving project maintainability and aligning with mando dropping Python 2 support in v0.8.0 (drop python2 support, six mando#57)Python 2 incompatibility
This can be resolved by installing
futures
.python2.7 -m pip install futures
However an additional error is encountered within configuration parsing.
Code optimisations have been largely applied by the ruff linter through its
--fix
functionality; using the pyupgrade (UP) ruleset.Python 3.3 incompatibility
Package installation fails with Python 3.3 as installation of an incompatible distribution of
colorama
is attempted which is only supported from Python 3.4.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
encoding
keyword argument can be provided withopen
inPyPy