New explorer structure #233
Open
+1,049
−300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklps
reviewed
Oct 21, 2024
gklps
reviewed
Oct 21, 2024
gklps
reviewed
Oct 21, 2024
gklps
reviewed
Oct 21, 2024
core/explorer.go
Outdated
| c.log.Error("Failed to initialise storage ExplorerUserDetails ", "err", err) | ||
| return err | ||
| } | ||
|
|
||
| url := "deamon-explorer.azurewebsites.net" |
There was a problem hiding this comment.
shouldnt these URL be coming from explorer db?
There was a problem hiding this comment.
It is coming from db when making requests. But while initialising the ExplorerURLTable, its adding the mainnet or testnet explorer link. This was there since earlier. Didn't make any changes here. Should I remove these links?
gklps
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the explorer structures as per the new explorer format.