Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub test #74

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add sub test #74

wants to merge 19 commits into from

Conversation

Apachina
Copy link
Collaborator

@Apachina Apachina commented Aug 31, 2018

Создавая пуллреквест, я:

  • убедился, что diff измненеий содержит только внесеные мной изменения
  • проверил, что закоментированный код удален (это касается именно закоментированного кода, а не настроек гемов)
  • проверил, что PR не содержит пустых ненужных файлов
  • запустил ./checkers и rspec
  • проверил именование переменных и методов и их соответвие соглашениям

@Apachina Apachina changed the title Add page for sub test Add sub test Aug 31, 2018
@Apachina Apachina closed this Sep 3, 2018
@Apachina Apachina reopened this Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant