Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link "change course" in setting #79

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add link "change course" in setting #79

wants to merge 3 commits into from

Conversation

Apachina
Copy link
Collaborator

@Apachina Apachina commented Aug 31, 2018

Создавая пуллреквест, я:

  • убедился, что diff измненеий содержит только внесеные мной изменения
  • проверил, что закоментированный код удален (это касается именно закоментированного кода, а не настроек гемов)
  • проверил, что PR не содержит пустых ненужных файлов
  • запустил ./checkers и rspec
  • проверил именование переменных и методов и их соответвие соглашениям

= link_to t('.cancel_my_account'), registration_path(resource_name), data: { confirm: t('.are_you_sure') }, method: :delete, class:"alert alert-danger"
br
br
= link_to t('.change_course'), level_users_path, data: {confirm:"If you change your course you lost all information about befor course"}, class:"alert alert-success"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Без локализации? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -5,7 +5,7 @@
p
| Free 15-minute
p
| English lessons
| English lessons
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants