This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
2333-3 #281
Open
2333-3 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 27, 2018
2333/3/helpers/rating_counter.rb
Outdated
|
|
||
| def prepare_data_for_request | ||
| @comments.each_with_index do |comment, index| | ||
| @data[:documents] << { id: index.to_s, language: 'ru', text: comment} |
There was a problem hiding this comment.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
|
God commits are unacceptable. Please, remember it. |
alexshagov
suggested changes
Jul 30, 2018
| erb :add_article | ||
| end | ||
|
|
||
| post '/articles/add' do |
There was a problem hiding this comment.
Stick to RESTful routes.
e.g.
- POST '/articles'
- GET '/article/:id' (as you've done already)
2333/3/helpers/article_builder.rb
Outdated
|
|
||
| # the class that creates an article | ||
| class ArticleBuilder | ||
| def initialize(link, key) |
There was a problem hiding this comment.
You pass key through all of the classes. Why?
You could just use it in one class responsible for comments analysis.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Номер
2333
Номер задания
3
Ссылка на видео с демо
https://youtu.be/3rPRb68eslc
Комментарии
Задание выполнено, но хочу еще добавить некоторых изменений