This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
2227-3 #283
Open
2227-3 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 27, 2018
| # Controller Sinatra | ||
|
|
||
| module ArticlesController | ||
| def self.registered(app) |
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for registered is too high. [18.44/15]
Metrics/MethodLength: Method has too many lines. [17/10]
| # Controller Sinatra | ||
|
|
||
| module ArticlesController | ||
| def self.registered(app) |
There was a problem hiding this comment.
TooManyStatements: ArticlesController#self.registered has approx 13 statements. More info.
stahor
reviewed
Jul 27, 2018
| @@ -0,0 +1,29 @@ | |||
| # Controller Sinatra | |||
| # rubocop:disable Metrics/AbcSize, Metrics/MethodLength | |||
stahor
reviewed
Jul 27, 2018
| end | ||
|
|
||
| def import_json_from_api | ||
| "https://comments.api.onliner.by/news/tech.post/#{search_post_id}/comments?limit=#{COMMENTS_LIMIT}" |
There was a problem hiding this comment.
I wanna see 50 top rated comments. Not just first 50
stahor
reviewed
Jul 27, 2018
| end | ||
|
|
||
| def create_article_stat | ||
| texts.each_with_index { |text, index| article.comments.add(Comment.create(text: text, rating: ratings[index])) } |
There was a problem hiding this comment.
ok, in ur ideal world azure returns scores in the same order. In the real world tomorrow they will shuffle these scores. I want to be sure that comments will be saved with correct rating.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Номер
2227
Номер задания
3
Ссылка на видео с демо
https://youtu.be/_G65r33RaVc
Комментарии
Веб-приложение работает, но это раняя версия, многое можно улучшить.