FactoryBot/AssociationStyle nested factories

[jaydorsey]

Makes factory an explicit name to address nested factory edge case

fixes #113

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

• Added the new cop to config/default.yml.
• The cop is configured as Enabled: pending in config/default.yml.
• The cop documents examples of good and bad code.
• The tests assert both that bad code is reported and that good code is not reported.
• Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

• Set VersionChanged: "<<next>>" in config/default.yml.

[pirj]

Looks good, thank you for handling this!

Can you please add a changelog entry? (You would have to add yourself to the list of contributors at the bottom of the file, sorted alphabetically).

[pirj]

Is it fair to say that this pr fixes #113?
Please feel free to remove this from the description if there will still be something to address wheb this is merged.

[jaydorsey]

Is it fair to say that this pr fixes #113? Please feel free to remove this from the description if there will still be something to address wheb this is merged.

Yes, it does, thank you! I forgot to add the tag/annotation in the PR message. I'll make the update to the changelog and take a look at the spec name as well

[pirj]

Thank you!

RuboCop failure is unrelated. Seems to be caused by some upstream internal cop change causing intolerance to the “it ‘register offense’” instead of “registers offense”.

[ydah]

Could you rebase it to the latest master branch?

[jaydorsey]

Could you rebase it to the latest master branch?

Done. If you could double-check it for me I'd appreciate it. I think I've got it rebased & squashed correctly but it's always nice to have a 2nd set of eyes

Thanks!

[ydah]

Looks good! Thank you for your work❤️