Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rails 7.1 in test suite + compatibility #2353

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Add Rails 7.1 in test suite + compatibility #2353

merged 5 commits into from
Oct 12, 2023

Conversation

ericproulx
Copy link
Contributor

Add Rails 7.1 in test suite + compatibility

dblock
dblock approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nit on CHANGELOG. Do we need to make any updates to README? We say a few things about beta versions of Rails, maybe we should add something about Rails 7?

CHANGELOG.md Outdated Show resolved Hide resolved
@ericproulx
Copy link
Contributor Author

Looks great! Nit on CHANGELOG. Do we need to make any updates to README? We say a few things about beta versions of Rails, maybe we should add something about Rails 7?

Maybe something about the railtie for Rails 7. I'll write something

@ericproulx
Copy link
Contributor Author

Looks great! Nit on CHANGELOG. Do we need to make any updates to README? We say a few things about beta versions of Rails, maybe we should add something about Rails 7?

Maybe something about the railtie for Rails 7. I'll write something

@dblock done

@dblock dblock merged commit 4e2a2ff into ruby-grape:master Oct 12, 2023
31 checks passed
@dblock
Copy link
Member

dblock commented Oct 12, 2023

Merged, thanks for taking care of it.

@kaylareopelle kaylareopelle mentioned this pull request Oct 20, 2023
Closed
@schinery schinery mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericproulx @dblock