fix(#2195): Fix declared
method for hash params with overlapping names
#2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I was taking a look to the issue #2195 .
Seems the error is because the logic inside the
handle_passed_param
method is using thestart_with?(key)
method. So, if we have two params like:empty_hash
and:empty_hash_two
, as both of them share part of the key, it detects that the:empty_hash
parameter has children, and it behaves in a different way and it ends returning anil
value.For solving it, I'm checking that for having children the key of the children should start with the same key name + a
[
. Maybe not the better solution for checking this 🤔 so open to discussion.