Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file method #2500

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Conversation

ericproulx
Copy link
Contributor

This PR removes the deprecated file method.

@ericproulx ericproulx marked this pull request as ready for review September 25, 2024 16:34
@ericproulx ericproulx requested a review from dblock September 25, 2024 17:30
@dblock
Copy link
Member

dblock commented Sep 25, 2024

Which version did we deprecate this in? If it's < 2.x then let's delete. Otherwise I think we should have a policy of deprecating in one major and deleting in the next major.

@ericproulx
Copy link
Contributor Author

Which version did we deprecate this in? If it's < 2.x then let's delete. Otherwise I think we should have a policy of deprecating in one major and deleting in the next major.

1.4.0. It's been a while

@dblock dblock merged commit 75e8c5b into ruby-grape:master Sep 26, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants