Delegates calls to inner object is some classes by extends Forwardable #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instance_for_rack Use `delegate_missing_to` instead of method_missing Add forwardable in endpoint.rb. Delegate `params` and `headers` to `request` Remove LazyObject for build_headers since its not forced in endpoint.rb anymore. Small refactor to request.rb Use `each_header` from Rack::Request instead of `env.each_pair` Remove `.to_s` since Ruby 2.7 added `start_with?` to symbols Add forwardable in stack.rb.
Generated by 🚫 Danger |
|
LGTM, YOLO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will delegate some functions to some inner objects. Here are the details:
api.rb
Add delegation to
base_instanceandinstance_for_rackUse
delegate_missing_toinstead of method_missing functionsendpoint.rb
Delegate
paramsandheaderstorequestRemove
LazyObjectforbuild_headerssince its not forcedrequest.rb
Use
each_headerfrom Rack::Request instead ofenv.each_pairRemove
.to_ssince Ruby 2.7 addedstart_with?to symbolsstack.rb
Delegates some functions