Ruby 3.4 Hash#inspect compatibility.
#709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radar
approved these changes
Dec 9, 2024
|
Thank you! Could you please exclude Rails 6.1 + ruby-head from the matrix? |
voxik
force-pushed
the
ruby-3.4
branch
2 times, most recently
from
fa26c6c to
b0685b8
Compare
These are required for Ruby 3.4 support, which extracts `base64` / `mutex_m` into bundled gem. The maintained versions of Rails have the dependencies updated.
I have included this patch if you prefer: diff --git a/gemfiles/Gemfile.rails-6.1.x b/gemfiles/Gemfile.rails-6.1.x
index 6f67f78..43481a6 100644
--- a/gemfiles/Gemfile.rails-6.1.x
+++ b/gemfiles/Gemfile.rails-6.1.x
@@ -8,6 +8,8 @@ gem 'test_declarative', '0.0.6'
gem 'rake'
gem 'minitest', '~> 5.14'
gem 'racc'
+gem 'base64'
+gem 'mutex_m'
platforms :mri do
gem 'oj' |
Rails 8.1 requires Ruby 3.2 at minimum:
~~~
Bundler found conflicting requirements for the Ruby
In Gemfile.rails-main:
activesupport was resolved to 8.1.0.alpha, which depends on
Ruby (>= 3.2.0)
~~~
I'll do that. But it seems the matrix is incomplete. Rails 7.2 / 8.0 should likely be added. |
|
Agree. Make it so :)
…On Wed, Dec 11, 2024, at 3:35 AM, Vít Ondruch wrote:
> And this combo: https://github.com/ruby-i18n/i18n/actions/runs/12235161164/job/34125870227?pr=709
>
I'll do that. But it seems the matrix is incomplete. Rails 7.2 / 8.0 should likely be added.
—
Reply to this email directly, view it on GitHub <#709 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAU73UADXUJJ4PQKZVHNL2E4J3ZAVCNFSM6AAAAABTIVKC6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZSGIZTGNZZGU>.
You are receiving this because you commented.Message ID: ***@***.***>
|
voxik
force-pushed
the
ruby-3.4
branch
3 times, most recently
from
7e23f2e to
2399852
Compare
Done. I have noticed that Also, I'd say that the JRuby might need review. |
radar
approved these changes
Dec 12, 2024
|
Thank you for your diligence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.