Update to phlex 2 beta #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirdes
approved these changes
Oct 8, 2024
| @@ -1,6 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class Docs::ComponentsTable < ApplicationComponent | |||
| class Components::Docs::ComponentsTable < Components::Base | |||
There was a problem hiding this comment.
you already are on Components directory, it means that you can use only Base make it less verbose
Components::Docs::ComponentsTable < Base
or even better:
module Components
module Docs
ComponentsTable < Base
end
end
end
bin/files_out
Outdated
| @@ -0,0 +1,34 @@ | |||
| #!/bin/bash | |||
|
fixed by #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is updating phlex to version 2. There were quite a few changes needed