Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs view for pagination component #83

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

schodevio
Copy link
Contributor

  • Docs view for pagination components

@schodevio schodevio changed the title Draft: Add docs view for pagination component Add docs view for pagination component Mar 10, 2024
@sethhorsley
Copy link
Collaborator

I update the phlex_ui gem with your changes last thing here is to update the phlex ui gem just run:
bundle update phlex_ui
and repush and i can merge.
that will make all tests pass

@sethhorsley
Copy link
Collaborator

Awesome. Was there a reason you needed to update the database.yml? If not lets revert that and it looks ready to merge.

@schodevio schodevio force-pushed the feat/pagination-components branch from 8914d0c to be789b0 Compare March 10, 2024 12:18
@schodevio
Copy link
Contributor Author

No, I've just noticed this too. Fixed

@sethhorsley sethhorsley merged commit bdc1f3c into ruby-ui:main Mar 10, 2024
3 checks passed
@schodevio schodevio deleted the feat/pagination-components branch March 10, 2024 12:22
@sethhorsley
Copy link
Collaborator

Do you have a twitter or some social media i can add you?
I wanted to @ you in the discord for helping out with phlex_ui and also should start the release notes and add new contributers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants