Moved Grammar unit tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmenezesds
commented
Aug 4, 2023
spec/spec_helper.rb
Outdated
| Kernel.srand config.seed | ||
|
|
||
| # Allow to limit the run of the specs | ||
| config.filter_run_when_matching :focus |
There was a problem hiding this comment.
The attention point for having this enabled is that if someone forgets the focus on the code, then this would be a problem since most of the tests would be skipped.
So I'd like your opinion on this matter
There was a problem hiding this comment.
I prefer to NOT set this configuration because it's risky and costly to check each PR does not introduce focus method (e.g. fit). Could you remove this configuration?
yui-knk
reviewed
Aug 26, 2023
spec/lrama/grammar/code_spec.rb
Outdated
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Please add new line on the end of a file.
yui-knk
reviewed
Aug 26, 2023
spec/spec_helper.rb
Outdated
|
|
||
| # Randomize specs run order. | ||
| config.order = :random | ||
| Kernel.srand config.seed |
There was a problem hiding this comment.
I feel this code bit tricky. I guess the intention is to fix seed of Kernel#rand. However IIRC at the moment there is no dependency for such randomness.
- Moved and renamed file from `spec/lrama/grammar_spec.rb` to `spec/lrama/grammar/symbol_spec.rb` - Added randomization to rspec tests and option to allow focusing test cases
- Removed extra describe - Changed to use described_class instead
lucasmenezesds
force-pushed
the
grammar-unit-tests
branch
from
f668c48 to
2f905d8
Compare
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Commit
Commit
RSpec.describe Lrama::Grammar do)described_classinstead ofLrama::Grammar::SymbolCommit