Don't use OpenSSL session cache on JRuby #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRuby's implementation of the `openssl` library does not support session caching, so this results in errors and prevents the library from working. With the given patch all but one test pass on JRuby. See jruby/jruby#6682 (comment)
|
@shugo @hsbt If we can get this merged and released soon, that would be a big help! A user reported that all released versions of net-ftp are broken on JRuby, so we are eager to resolve that! There's still one failure in the test suite on JRuby after this change, so I'll look at that separately after release. |
34 tasks
hsbt
approved these changes
Jun 25, 2024
|
@hsbt You're the best, thanks! 🙏 |
headius
added a commit
to headius/jruby
that referenced
this pull request
Jun 26, 2024
Previous versions were missing our patch to disable OpenSSL session caching. See ruby/net-ftp#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby's implementation of the
openssllibrary does not support session caching, so this results in errors and prevents the library from working.With the given patch all but one test pass on JRuby.
See jruby/jruby#6682 (comment)