✨ Add secret alias (for password, oauth2_token, etc) to relevant SASL mechanisms
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2023
nevans
force-pushed
the
sasl/secrets-kwarg
branch
from
ff55f27
to
1d74a33
Compare
`secret` is similar to `username`: a convenient alias with ambiguous semantics. Adding it is reasonable, but I probably wouldn't add it only for `Net::IMAP`. However, `Net::SMTP` uses it, and probably others would find it useful too.
nevans
force-pushed
the
sasl/secrets-kwarg
branch
from
1d74a33
to
1cb0c17
Compare
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secretis similar tousername: a convenient alias with ambiguous semantics. Adding it is reasonable, but I probably wouldn't add it only forNet::IMAP. However, relevant to #23,Net::SMTPuses it and probably others would find it useful too.