Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Replace removed method in example for OpenSSL::Config#to_s #805

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

hoshi-sano
Copy link
Contributor

OpenSSL::Config#[]= is used in OpenSSL::Config#to_s example,

* Given the following configuration being created:
*
* config = OpenSSL::Config.new
* #=> #<OpenSSL::Config sections=[]>
* config['default'] = {"foo"=>"bar","baz"=>"buz"}
* #=> {"foo"=>"bar", "baz"=>"buz"}

even though it was removed by #342 .

Other two methods are removed because the corresponding functions
disappeared in OpenSSL 1.1.0.

  • OpenSSL::Config#add_value
  • OpenSSL::Config#[]=
irb(main):001> RUBY_VERSION
=> "3.3.5"
irb(main):002> OpenSSL::VERSION
=> "3.2.0"
irb(main):003> OpenSSL::OPENSSL_VERSION
=> "OpenSSL 3.0.2 15 Mar 2022"
irb(main):004> config = OpenSSL::Config.new
=> #<OpenSSL::Config sections=[]>
irb(main):005> config['default'] = {"foo"=>"bar","baz"=>"buz"}
(irb):5:in `<main>': undefined method `[]=' for an instance of OpenSSL::Config (NoMethodError)

@rhenium rhenium merged commit c8693f1 into ruby:master Oct 31, 2024
54 of 56 checks passed
@rhenium
Copy link
Member

rhenium commented Oct 31, 2024

Good catch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants