Should raise ParsingError instead of NoMethodError #1675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a record type pattern that resulted in a
NoMethodError
instead of aParsingError
, so I fixed it.It seems that if the record key starts with Symbol, String, Integer, true, or false, and is not a literal type, the
literal
method cannot be called, resulting in a NoMethodError.Although it is not impossible to optimize the code for each token in detail, I think that using
parse_simple
is a reasonable fix.