RFC: new Attribute#ivar API
#2110
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
commented
Dec 2, 2024
| @@ -304,6 +304,21 @@ def update(name: self.name, type: self.type, ivar_name: self.ivar_name, kind: se | |||
| visibility: visibility | |||
| ) | |||
| end | |||
|
|
|||
| def ivar | |||
There was a problem hiding this comment.
Now the semantics are clear: You either get back an InstanceVariable object, or nil (meaning this attribute was declared with no backing ivar declaration, e.g. attr_reader foo(): Foo).
Open question: How should we model the difference between these two?
attr_reader a: Foo # Ivar name is inferred
attr_reader a(@a): Foo # Same ivar name, but explicit| @@ -185,6 +185,8 @@ module RBS | |||
| include _HashEqual | |||
|
|
|||
| def update: (?name: Symbol, ?type: Types::t, ?ivar_name: Symbol | false | nil, ?kind: kind, ?annotations: Array[Annotation], ?location: loc?, ?comment: Comment?, ?visibility: visibility?) -> instance | |||
|
|
|||
| def ivar: () -> InstanceVariable? | |||
There was a problem hiding this comment.
Simple return type! :)
There was a problem hiding this comment.
Does it still make sense for ivar_name to accept false in the constructor and the attr_reader?
amomchilov
force-pushed
the
new-attr-ivar-api
branch
from
1fff94e
to
e406183
Compare
amomchilov
commented
Dec 2, 2024
| self.ivar_name # Use the custom instance variable name given by the user | ||
| end | ||
|
|
||
| InstanceVariable.new(name: ivar_name, type: type, location: location, comment: comment) |
There was a problem hiding this comment.
Open question: what should the location and comment be? The same as the attribute, or nil?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal for fixing #2109. Feedback welcome!