Fix UNIXSocket#send_io and recv_io types #2264
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the method type definitions for
UNIXSocket#{send_io,recv_io}
.send_io
https://docs.ruby-lang.org/en/3.3/UNIXSocket.html#method-i-send_io
send_io
actually receives an IO, but the type definition only acceptsBasicSocket
, which is a subclass ofIO
. So I fixed it to allowIO
.recv_io
https://docs.ruby-lang.org/en/3.3/UNIXSocket.html#method-i-recv_io
It's a bit complex. It has three patterns.
IO
.Integer
class or nil, it returns an Integer.for_fd
method, it calls this method and returns the returned value offor_fd
.for_fd
is the file descripter. The second argument ismode
, and the second argument ofrecv_io
.