Reverse Rubocop’s misunderstanding.

MailingList is not an ActiveRecord model.
rubyaustralia · Dec 17, 2023 · bf193a0 · bf193a0
1 parent c5ef3b5
commit bf193a0
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 13 deletions.
diff --git a/app/lib/mailing_list.rb b/app/lib/mailing_list.rb
@@ -13,6 +13,10 @@ def self.all
     @all ||= LISTS.collect { |name| new name }
   end
 
+  def self.each(...)
+    all.each(...)
+  end
+
   def initialize(name)
     @name = name
   end

diff --git a/app/lib/mailing_list/create_webhooks.rb b/app/lib/mailing_list/create_webhooks.rb
@@ -2,7 +2,7 @@
 
 class MailingList::CreateWebhooks
   def self.call
-    MailingList.all.find do |list|
+    MailingList.each do |list|
       new(list).call
     end
   end

diff --git a/app/lib/mailing_list/setup.rb b/app/lib/mailing_list/setup.rb
@@ -2,7 +2,7 @@
 
 class MailingList::Setup
   def self.call(user)
-    MailingList.all.find do |list|
+    MailingList.each do |list|
       new(user, list).call
     end
   end

diff --git a/app/lib/mailing_list/sync.rb b/app/lib/mailing_list/sync.rb
@@ -2,7 +2,7 @@
 
 class MailingList::Sync
   def self.call
-    MailingList.all.find do |list|
+    MailingList.each do |list|
       new(list).call
     end
   end

diff --git a/app/models/user.rb b/app/models/user.rb
@@ -61,22 +61,18 @@ def set_up_mailing_list_flags
   def subscribe_to_lists
     return if skip_subscriptions
 
-    # rubocop:disable Rails/FindEach
-    MailingList.all.each do |list|
+    MailingList.each do |list|
       next unless mailing_lists[list.name] == "true"
 
       MailingList::Subscribe.call self, list
     end
-    # rubocop:enable Rails/FindEach
   end
 
   def update_mailing_list_email_addresses
-    # rubocop:disable Rails/FindEach
-    MailingList.all.each do |list|
+    MailingList.each do |list|
       next unless mailing_lists[list.name] == "true"
 
       MailingList::Update.call self, list
     end
-    # rubocop:enable Rails/FindEach
   end
 end
diff --git a/app/views/devise/registrations/new.html.erb b/app/views/devise/registrations/new.html.erb
@@ -85,7 +85,7 @@
 
       <div class="hint">You can choose to subscribe to news about each of our major events. If you are already subscribed to any of these lists, those subscriptions will be honoured.</div>
 
-      <% MailingList.all.each do |list| %>
+      <% MailingList.each do |list| %>
         <div class="field flipped">
           <div class="input">
             <%= hidden_field_tag "user[mailing_lists][#{list.name}]", "false" %>

diff --git a/app/views/my/details/edit.html.erb b/app/views/my/details/edit.html.erb
@@ -59,7 +59,7 @@
   <fieldset>
     <legend>Mailing Lists</legend>
 
-    <% MailingList.all.each do |list| %>
+    <% MailingList.each do |list| %>
       <div class="field flipped">
         <div class="input">
           <%= hidden_field_tag "user[mailing_lists][#{list.name}]", "false" %>

diff --git a/spec/features/committee_manages_list_webhooks_spec.rb b/spec/features/committee_manages_list_webhooks_spec.rb
@@ -4,13 +4,13 @@
 
 RSpec.feature "Committee manages list webhooks", type: :request do
   scenario "registering webhooks" do
-    MailingList.all.find do |list|
+    MailingList.each do |list|
       stub_request(:post, "https://api.createsend.com/api/v3.3/lists/#{list.api_id}/webhooks.json")
     end
 
     MailingList::CreateWebhooks.call
 
-    MailingList.all.find_each do |list|
+    MailingList.each do |list|
       expect(
         a_request(:post, "https://api.createsend.com/api/v3.3/lists/#{list.api_id}/webhooks.json")
       ).to have_been_made