New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ferrum v0.15 with proxy #34

Merged

route merged 1 commit into rubycdp:main from milk1000cc:fix/support-ferrum-v0.15-with-proxy

Jun 29, 2024

Contributor

milk1000cc commented Jun 28, 2024

When using a proxy with ferrum v0.15, I get the following error

lib/vessel/driver/ferrum/page.rb:20:in `close': undefined method `context' for an instance of Ferrum::Page (NoMethodError)

          page.context.dispose if page.use_proxy?
              ^^^^^^^^

This is probably because Ferrum::Page#context was removed in ferrum v0.15.

See also: rubycdp/ferrum#431


          fix: support ferrum v0.15 with proxy

30d8fbf

route merged commit 2b45c17 into rubycdp:main

4 of 5 checks passed

Member

route commented Jun 29, 2024

Right you are! Thanks!

milk1000cc deleted the fix/support-ferrum-v0.15-with-proxy branch

June 29, 2024 23:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet