Make the code in scanner/groovy.rb robust. #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix small issues for
lib/coderay/scanners/groovy.rb
.inline_block_paren_depth
is initialized asnil
.But the code
inline_block_paren_depth += 1
,inline_block_paren_depth -= 1
,inline_block_paren_depth == 0
has a possibility to raise unintendedNoMethodError
.It looks good to initialize
inline_block_paren_depth
is initialized as0
or add checks before the codes.string_delimiter
can benil
as a possibility. Adding checks looks better.