fix mobile header #569
Merged
fix mobile header #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareg0
reviewed
Nov 8, 2017
| @@ -5,14 +5,13 @@ | |||
| <title>RoRganize.it | Find a Rails Girls Study Group</title> | |||
| <%= stylesheet_link_tag (params[:redesign] ? 'redesign' : 'application'), media: "all" %> | |||
| <%= csrf_meta_tags %> | |||
| <link href='//fonts.googleapis.com/css?family=Pacifico' rel='stylesheet' type='text/css'> | |||
sareg0
reviewed
Nov 8, 2017
| @@ -5,14 +5,13 @@ | |||
| <title>RoRganize.it | Find a Rails Girls Study Group</title> | |||
| <%= stylesheet_link_tag (params[:redesign] ? 'redesign' : 'application'), media: "all" %> | |||
There was a problem hiding this comment.
Do you think we can also get rid of this? We can start a new issue for it, so as not to scope creep this one.
There was a problem hiding this comment.
Ah, good catch! I can definitely remove that
|
Thanks soooo much for this. Since there is a fair bit of re-organization of the files, could you point out the fixes that solve the particular UI issues? Sorry for closing accidentally 🤦♀️ |
lislis
commented
Nov 8, 2017
|
|
||
| $navbar-height-reduced: 78px; // some weirdness on smaller screens | ||
|
|
||
| nav.navbar { |
There was a problem hiding this comment.
@sareg0 most things happen here. I changed the flex-order of the elements that appear in the header to better fit smaller screens. Some elements were also hidden on mobile devices which are now always visible
|
@sareg0 sure thing! I left a comment in the files :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #519
Logo, main-nav and profile-nav are now visible and usable on every screen size