Amend ruby version in docker image and documentation #750
Conversation
| @@ -1,6 +1,6 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| ruby file: ".ruby-version" | |||
| ruby "3.2.3" | |||
There was a problem hiding this comment.
Do we need to add the .ruby-version file to the Dockerfile context?
There was a problem hiding this comment.
I don't think so. And personally i like hardcoding it too -- .ruby-version is really for your editor and maybe its better to globally git ignore your preferred toolset (I like asdf for example, so i get .tool-versions)
Gemfile will stop and give the right error message if your Ruby is wrong version and changing ruby to ME is something you just do
There was a problem hiding this comment.
Ah yes - I believe you're right in terms of fixing the error screenshot I posted.
Saying that, I don't feel strongly either way whether this should be hard-coded or linked to the .ruby-version file. I do agree however that it can get confusing having multiple files determining versions.
I personally use .tool-versions, but I think the dockerisation can be agnostic of this.
| @@ -1,6 +1,6 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| ruby file: ".ruby-version" | |||
| ruby "3.2.3" | |||
There was a problem hiding this comment.
I don't think so. And personally i like hardcoding it too -- .ruby-version is really for your editor and maybe its better to globally git ignore your preferred toolset (I like asdf for example, so i get .tool-versions)
Gemfile will stop and give the right error message if your Ruby is wrong version and changing ruby to ME is something you just do
|
Seems fine |
No description provided.