Add Javascript test line numbers #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 23, 2020 17:51
Note: this does not add accurate column numbers. We can add them, though it may have a performance impact Also, this skips source maps for the node_modules folder. On my machine, this sped up compilation time from 2.51s to 1.38s
h-m-m
commented
Apr 23, 2020
| }, | ||
| "scripts": { | ||
| "test": "mochapack --webpack-config config/webpack/test.js --require test/setup.js test/**/*.spec.js" | ||
| "test": "mochapack --webpack-config config/webpack/test.js --require spec/javascript/setup.js --colors 'spec/javascript/**/*.spec.js'" |
There was a problem hiding this comment.
Without the quotes around the glob pattern, it's possible for some wonky shell interpolation to kick in instead of letting mocha handle it
h-m-m
commented
Apr 23, 2020
| devtoolFallbackModuleFilenameTemplate: '[absolute-resource-path]?[hash]' | ||
| }, | ||
| mode: 'development', | ||
| externals: [nodeExternals()], |
There was a problem hiding this comment.
On my machine, this line sped up compilation time from 2.51s to 1.38s. Though I think it was closer to 0.84s as of a day or two ago (before adding source maps)
h-m-m
force-pushed
the
javascript-test-line-numbers
branch
from
abbe5ca
to
2ebecf9
Compare
h-m-m
commented
Apr 23, 2020
|
|
||
| const babelLoader = environment.loaders.get('babel') | ||
| babelLoader.include.push(babelLoader.include[0].concat('../../test')) |
There was a problem hiding this comment.
This doesn't seem to be necessary anymore 🤷
I assume #71 made the difference
solebared
approved these changes
Apr 24, 2020
h-m-m
commented
Apr 24, 2020
| "--require", "spec/javascript/setup.js", | ||
| "--timeout", "999999", | ||
| "--colors", | ||
| "spec/javascript/**/*.spec.js" |
There was a problem hiding this comment.
I am looking forward to sysgears/mochapack#63 being resolved so that this file can reference a script in package.json instead of the args here potentially getting out of sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@exbinary pointed out how test errors weren't very helpful, so I looked into it
Note: this does not add accurate column numbers. We can add them, though it may have a performance impact
I created a test with a deliberate typo to get screenshots:
Before:
After:
(Yes, also more color 🌈 )