-
Notifications
You must be signed in to change notification settings - Fork 208
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Move docs header to a partial Analogous to the blog header one. * Bump haml to 6.3 There were two issues: * Pages using the two column layout were duplicating content. I identified the issue as related to the weird usage of `content_for` inside `wrap_layout`. I removed that because it was also making the template structure harder to follow. * Sometimes HTML entities were not being properly interpreted. Fixed by switching to use `!=` in those cases. Signed-off-by: Takuya Noguchi <[email protected]> --------- Signed-off-by: Takuya Noguchi <[email protected]> Co-authored-by: Takuya Noguchi <[email protected]>
- Loading branch information
1 parent
f35066a
commit 1e99a26
Showing
7 changed files
with
19 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,5 @@ | |
|
||
~ yield | ||
|
||
= yield_content :tail | ||
|
||
.footer | ||
= partial 'layouts/footer' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,18 +5,8 @@ | |
- content_for(:canonical, commands_toplevel_path(current_page.destination_path)) | ||
|
||
~ wrap_layout :base do | ||
- content_for :tail do | ||
.bg-light-blue | ||
.container | ||
.contents | ||
.edit-on-github.text-center | ||
= link_to_editable_version | ||
= partial 'partials/docs_header' | ||
|
||
.bg-light-blue.header | ||
= image_tag '/images/docs_header_transparent_bg.png', | ||
srcset: '/images/docs_header_transparent_bg.png 1x, /images/[email protected] 2x, /images/[email protected] 3x', | ||
class: 'img-fluid header-padding', | ||
style: 'max-width: 400px;' | ||
.container | ||
.row.flex-column.flex-md-row-reverse | ||
.col-12.col-md-9.contents#page-content-wrapper{ class: is_command ? "commands" : "guide" } | ||
|
@@ -29,3 +19,9 @@ | |
= partial 'partials/guides_sidebar' | ||
|
||
= javascript_include_tag 'two_column_layout.min' | ||
|
||
.bg-light-blue | ||
.container | ||
.contents | ||
.edit-on-github.text-center | ||
= link_to_editable_version |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
.bg-light-blue.header | ||
= image_tag '/images/docs_header_transparent_bg.png', | ||
srcset: '/images/docs_header_transparent_bg.png 1x, /images/[email protected] 2x, /images/[email protected] 3x', | ||
class: 'img-fluid header-padding', | ||
style: 'max-width: 400px;' |