Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing /whats_new.html page #1427

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add missing /whats_new.html page #1427

merged 2 commits into from
Jan 15, 2025

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user problem that led to this PR?

The problem was the getting started page includes a link to Bundler 2.4 what's new page.

Instead, it should link to the latest version.

What was your diagnosis of the problem?

My diagnosis was that this page started being missing when it was migrated to HAML in f2c455d, because we create proxy pages, but only for .haml pages:

bundler-site/config.rb

Lines 49 to 58 in cf57e55

# Make documentation for the latest version available at the top level, too.
# Any pages with names that conflict with files already at the top level will be skipped.
Dir.glob("./source/#{config[:current_version]}/*.haml").each do |file_path|
file_path = file_path.sub(/\.haml$/, "")
page_path = file_path.sub(/^\.\/source\//, "")
proxy_path = file_path["./source/#{config[:current_version]}/".length..-1]
proxy proxy_path, page_path unless file_exist?(proxy_path)
end

It was replaced with a hardcoded link to the v2.4 version, which was the latest at the time, but it got out of date.

What is your fix for the problem, implemented in this PR?

My fix is to create a symlink like we did in #1424.

Why did you choose this fix out of the possible options?

I chose this fix because because it's more SEO friendly that a client side redirect.

@deivid-rodriguez deivid-rodriguez marked this pull request as draft January 15, 2025 17:38
And link to it from version independent guide.
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review January 15, 2025 18:32
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More uniform, better! Thanks!

@olleolleolle olleolleolle merged commit 42d34dd into master Jan 15, 2025
3 checks passed
@olleolleolle olleolleolle deleted the fix-whats-new-link branch January 15, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants