Move onboarding controller tests to test/functional

These tests fit more with the functional paradigm since they are named after a controller and test one action at a time.
rubygems · Dec 4, 2024 · 39644ab · 39644ab
1 parent a786900
commit 39644ab
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/...ons/onboarding/confirm_controller_test.rb → ...ons/onboarding/confirm_controller_test.rb b/...ons/onboarding/confirm_controller_test.rb → ...ons/onboarding/confirm_controller_test.rb
diff --git a/...ations/onboarding/gems_controller_test.rb → ...ations/onboarding/gems_controller_test.rb b/...ations/onboarding/gems_controller_test.rb → ...ations/onboarding/gems_controller_test.rb
diff --git a/...ations/onboarding/name_controller_test.rb → ...ations/onboarding/name_controller_test.rb b/...ations/onboarding/name_controller_test.rb → ...ations/onboarding/name_controller_test.rb
diff --git a/...tions/onboarding/users_controller_test.rb → ...tions/onboarding/users_controller_test.rb b/...tions/onboarding/users_controller_test.rb → ...tions/onboarding/users_controller_test.rb
diff --git a/...egration/organizations/onboarding_test.rb → ...ganizations/onboarding_controller_test.rb b/...egration/organizations/onboarding_test.rb → ...ganizations/onboarding_controller_test.rb
@@ -8,7 +8,7 @@ class Organizations::OnboardingControllerTest < ActionDispatch::IntegrationTest
 
   context "GET /organizations/onboarding" do
     should "redirect to onboarding start page" do
-      get "/organizations/onboarding"
+      get organization_onboarding_path
 
       assert_redirected_to organization_onboarding_name_path
     end
@@ -18,7 +18,7 @@ class Organizations::OnboardingControllerTest < ActionDispatch::IntegrationTest
     should "not destroy an OrganizationOnboarding that is already completed" do
       organization_onboarding = create(:organization_onboarding, :completed, created_by: @user)
 
-      delete "/organizations/onboarding"
+      delete organization_onboarding_path
 
       assert_redirected_to dashboard_path
       assert OrganizationOnboarding.exists?(id: organization_onboarding.id)
@@ -27,7 +27,7 @@ class Organizations::OnboardingControllerTest < ActionDispatch::IntegrationTest
     should "destroy a pending OrganizationOnboarding created by the current user" do
       organization_onboarding = create(:organization_onboarding, created_by: @user)
 
-      delete "/organizations/onboarding"
+      delete organization_onboarding_path
 
       assert_redirected_to dashboard_path
       refute OrganizationOnboarding.exists?(id: organization_onboarding.id)
@@ -36,14 +36,14 @@ class Organizations::OnboardingControllerTest < ActionDispatch::IntegrationTest
     should "destroy a failed OrganizationOnboarding created by the current user" do
       organization_onboarding = create(:organization_onboarding, :failed, created_by: @user)
 
-      delete "/organizations/onboarding"
+      delete organization_onboarding_path
 
       assert_redirected_to dashboard_path
       refute OrganizationOnboarding.exists?(id: organization_onboarding.id)
     end
 
     should "redirect to the dashboarding if the current user has not started organization onboarding" do
-      delete "/organizations/onboarding"
+      delete organization_onboarding_path
 
       assert_redirected_to dashboard_path
     end