Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I18n] ES locale #4137

Merged
merged 29 commits into from
Oct 28, 2023
Merged

[I18n] ES locale #4137

merged 29 commits into from
Oct 28, 2023

Conversation

xuanxu
Copy link
Contributor

@xuanxu xuanxu commented Oct 17, 2023

This PR adds all missing translations for the spanish locale

@simi
Copy link
Member

simi commented Oct 17, 2023

👋 @Lastimoso @acrogenesis @javier-menendez would it be possible to take a look as previous contributors to es locale? @deivid-rodriguez feel free to check as well.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #4137 (3b66e76) into master (8876e8b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4137   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         302      302           
  Lines        6852     6852           
=======================================
  Hits         6765     6765           
  Misses         87       87           

config/locales/es.yml Outdated Show resolved Hide resolved
config/locales/es.yml Outdated Show resolved Hide resolved
config/locales/es.yml Outdated Show resolved Hide resolved
config/locales/es.yml Outdated Show resolved Hide resolved
config/locales/es.yml Outdated Show resolved Hide resolved
config/locales/es.yml Outdated Show resolved Hide resolved
xuanxu and others added 12 commits October 18, 2023 11:50
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
Co-authored-by: Javier Menéndez Rizo <[email protected]>
xuanxu and others added 4 commits October 18, 2023 11:54
Co-authored-by: Adrian Rangel <[email protected]>
Co-authored-by: Adrian Rangel <[email protected]>
Co-authored-by: Adrian Rangel <[email protected]>
Co-authored-by: Adrian Rangel <[email protected]>
@xuanxu
Copy link
Contributor Author

xuanxu commented Oct 18, 2023

@javier-menendez & @acrogenesis: Thanks!

@deivid-rodriguez
Copy link
Member

deivid-rodriguez commented Oct 18, 2023

Hei, I'm late here but sounds like others have already stepped in. This is great!

@xuanxu
Copy link
Contributor Author

xuanxu commented Oct 18, 2023

Conflict with master resolved.
Ready!

@javier-menendez
Copy link
Contributor

javier-menendez commented Oct 20, 2023

I'm still not sure about the word: mantenedores. Is not a word that is commonly used. I would use other variants like:

Maintainers wanted: Se solicita mantenimiento
Maintainer: Responsable de mantenimiento

@acrogenesis
Copy link
Contributor

I'm still not sure about the word: mantenedores. Is not a word that is commonly used. I would use other variants like:

Maintainers wanted: Se solicita mantenimiento Maintainer: Responsable de mantenimiento

I like Maintainer: Responsable de mantenimiento but I think Maintainers wanted: Se solicita mantenimiento doesn't send the right message. It says we need maintenance, not maintainers.
At least that's how I read it in Mexican Spanish.

I do use the word mantenedores referring to maintainers of OSS

@xuanxu
Copy link
Contributor Author

xuanxu commented Oct 20, 2023

  • I also use mantenedores for maintainers of OSS, but I'm ok with Responsable de mantenimiento too.

  • About Maintainers wanted: Se solicita mantenimiento, I'm with @acrogenesis here, I think it changes the original meaning of looking for people not for maintenance.

I'd like to have input from others about Mantenedores vs Responsable de mantenimiento to build a bigger consensus. WDYT @deivid-rodriguez ?

@javier-menendez
Copy link
Contributor

Maintainers wanted: Se solicita mantenimiento

I agree about that Maintainers wanted: Se solicita mantenimiento in that context can give the wrong message. I removed that suggestion. 👍

Copy link
Contributor Author

@xuanxu xuanxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, last suggestions merged.
Code updated to latest master and OIDC strings added.
This should be ready now.
cc/ @simi @segiddins

@deivid-rodriguez
Copy link
Member

I don't have a strong opinion on Mantenedores vs Responsable de mantenimiento, either works for me!

@simi simi merged commit 0c67b73 into rubygems:master Oct 28, 2023
15 checks passed
@simi
Copy link
Member

simi commented Oct 28, 2023

Thanks a lot everyone involved. Merging for now, feel free to open additional PR with additional tweaks if needed.

@xuanxu xuanxu deleted the es-locale branch October 29, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants