Use PR of zlib to try to reduce memory usage #4147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/zlib-pr
branch
from
7945d44 to
cecc525
Compare
Codecov Report
@@ Coverage Diff @@
## master #4147 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 279 279
Lines 6317 6317
=======================================
Hits 6247 6247
Misses 70 70 |
martinemde
approved these changes
Oct 21, 2023
| @@ -53,6 +53,7 @@ gem "browser", "~> 5.3", ">= 5.3.1" | |||
| gem "bcrypt", "~> 3.1", ">= 3.1.18" | |||
| gem "maintenance_tasks", "~> 2.1" | |||
| gem "strong_migrations", "~> 1.6" | |||
| gem "zlib", github: "ruby/zlib", ref: "refs/pull/61/head" | |||
There was a problem hiding this comment.
Does pointing to the PR ref mean it will randomly fail at some point when the PR is merged (am I being too optimistic? 🤓)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby/zlib#61