-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load rails 7.0 defaults #4388
Load rails 7.0 defaults #4388
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4388 +/- ##
==========================================
- Coverage 97.15% 97.15% -0.01%
==========================================
Files 391 391
Lines 8258 8257 -1
==========================================
- Hits 8023 8022 -1
Misses 235 235 ☔ View full report in Codecov by Sentry. |
2568392
to
3495714
Compare
0 clue why this would cause test failures, it should be no functional change |
That's strange. Could it be that other gems are relying on the old api? For example, what's with the deprecation all the sudden?
Either I'm crazy or that code doesn't have a reference to secrets (when I look again maybe it is the call to clearance). |
I believe the warnings are unrelated |
3495714
to
e2ee570
Compare
e2ee570
to
668c49e
Compare
668c49e
to
ad986b1
Compare
ad986b1
to
8f35b6d
Compare
8f35b6d
to
bf08a09
Compare
bf08a09
to
de0e397
Compare
… with UPDATE sql. - find_by_sql calls could be cached and are not meant to be used for data modifications - this changes returned value, but it seems it is used only in testing
…DATE sql. - find_by_sql calls could be cached and are not meant to be used for data modifications
@segiddins @martinemde something in this list https://github.com/rails/rails/blob/4d3e2910c680baad7c14d2797a53a6b72405149b/railties/lib/rails/application/configuration.rb#L219-L268 causes There were 2 places using |
No description provided.