Use importmap for avo stimulus component #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
force-pushed
the
martinemde/avo-javascript
branch
3 times, most recently
from
ec4a166 to
75c5733
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4469 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 391 391
Lines 8259 8259
=======================================
Hits 8024 8024
Misses 235 235 ☔ View full report in Codecov by Sentry. |
|
This seems to just not work. Avo is not doing great with CSP in general. The console is a mess. |
|
Fixed. Seems to work. Thanks @segiddins. |
martinemde
force-pushed
the
martinemde/avo-javascript
branch
from
ca54943 to
f0c95f7
Compare
segiddins
approved these changes
Feb 20, 2024
| const application = window.Stimulus.Application.start(); | ||
| application.register("nested-form", window.StimulusRailsNestedForm); | ||
| <% end %> | ||
| <%= javascript_importmap_tags "avo.custom" %> |
There was a problem hiding this comment.
Suggested change
| <%= javascript_importmap_tags "avo.custom" %> | |
| <%= javascript_importmap_tags "avo.custom" %> | |
Run bin/rails generate avo:js:install then update.
martinemde
force-pushed
the
martinemde/avo-javascript
branch
from
f0c95f7 to
14575c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These imports were missed in the original conversion to importmaps. Removes the blocker for #4464.
I can't figure out exactly where this component is used in avo to verify that it continues to work. @segiddins?