Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show email when handle is not present #4517

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

spk
Copy link
Contributor

@spk spk commented Mar 10, 2024

Ref #4281

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (85082d9) to head (184ce88).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4517   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         391      391           
  Lines        8258     8258           
=======================================
  Hits         8023     8023           
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the PR @spk.

@simi simi merged commit 0a19162 into rubygems:master Mar 11, 2024
17 checks passed
@spk spk deleted the password-mailer-change-pass-email branch March 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants